Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translucency support #26

Merged
merged 11 commits into from
Mar 18, 2021
Merged

Conversation

trevorvanhoof
Copy link
Contributor

You want to ignore resource.rc changes, and possibly you don't want the changes from 6ff7230.
Most risky change is the emissive & alpha reading code, only tested with Maya fbx exports at this point.

Copy link
Contributor

@seece seece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this! I added some nitpicks but it looks good.

Shaders/basic_specgloss.fs Outdated Show resolved Hide resolved
Shaders/pbr.fs Outdated Show resolved Hide resolved
Shaders/pbr.fs Outdated Show resolved Hide resolved
Shaders/pbr.fs Outdated Show resolved Hide resolved
src/Geometry.cpp Show resolved Hide resolved
@Gargaj
Copy link
Owner

Gargaj commented Mar 18, 2021

Could you also remove the .rc changes then too? I can't really merge selectively.

@trevorvanhoof
Copy link
Contributor Author

There you go!

@Gargaj Gargaj merged commit 8eb520a into Gargaj:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants