Use packageManager defined in package.json when yarn-version is not specified in yarn action
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbbowd
approved these changes
May 21, 2024
lzm0
force-pushed
the
yarn-upgrade
branch
3 times, most recently
from
942ccdd
to
e4a08e3
Compare
…ot specified in yarn action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every package manager needs a package manager to manage it's own version, which is why corepack exists.
It looks for the
packageManagerfield in package.json and make theyarncommand point to that version.So instead of hard-coding
yarn-versionto3.6.4in action.yml, we let corepack to decide which version to use.Note that if the yarn version is not specified in the action input nor in package.json, yarn classic (v1.22.22) will be used.