Match suffixes of multisuffix files #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anu48
reviewed
Apr 24, 2024
There was a problem hiding this comment.
From first glance, it looks good to me. The following workflow in lighthouse-e2e-resources utilizes this update and prettier fails as expected: https://github.com/GarnerCorp/lighthouse-e2e-resources/actions/runs/8824165005
jsoref
force-pushed
the
treat-extensions-more-generously
branch
from
50a334a
to
81b8469
Compare
rbbowd
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Anu48 reported that build-actions/prettier wouldn't match
file.cy.jsbased on*.jsbeing a supported prettier extension. I believe this should resolve that problem.The old code would treat
.cy.jsas the file extension and only match things explicitly based on that. The new code lets each supported extension match against the entire file name and if it hits, selects that directory as an included directory.As prettier can support an
.js.flowthe original code wouldn't support this case if you had a file namesomething.else.js.flow, so we definitely want to change the handling to allow for that.