fix crash upon saving after removing regions (reverted; Fix XML docs) #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlimeCubed
changed the title
This reverts commit 95e5a5c.
Garrakx
changed the title
Garrakx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CRS had XML doc comments, but the setting to make the actual .xml file was unchecked. This should fix that, modifying some comments to comply with the XML format and enabling the file's generation. There were many instances of public members without docstrings, so I've gone ahead and suppressed CS1591 in the project's properties. If you want to thoroughly document it later you should undo that change.
I've also set "copy local" to false for all dependencies, so the output folder should now contain only the mod's .dll, .xml, and .pdb files.
The game used to crash if you removed any region after visiting them because of leftover map files. This also fixes that. When saving, all maps for regions that no longer exist are purged from the save file instead of freezing without writing anything to disk. Saves may still be corrupted since den indices will be changed, but the slot itself will not be lost.