Separate files into modules #36
Conversation
| return self_pointer_like{func(*it)}; | ||
| } | ||
|
|
||
| #define CONTAINER_VIEW_ITERATOR_BINARY_PREDICATE(OP) \ |
There was a problem hiding this comment.
There is another such macro in this file I had missed
There was a problem hiding this comment.
Yup, I plan to do so in upcoming commits, as this one is only about moving files around and formatting
| OP data; \ | ||
| return *this; \ | ||
| } | ||
| #define CLAWS_TAGGED_DATA_PREFIX_OP(OP) \ |
There was a problem hiding this comment.
I'm not really convinced moving \ so far to the right helps with readability
There was a problem hiding this comment.
Hmm, actually I used clang-format with the configuration file from this repository, but I agree they were moved quite far. I will update the configuration file to align the \ as far left as possible
There was a problem hiding this comment.
Oh damn, that clang-format was supposed to be gone (clang format doesn't handle lambdas well, at least back then)
modules/iterator/CMakeSources.cmake
Outdated
|
|
||
| set(MODULE_PUBLIC_HEADERS | ||
| "${MODULE_PATH}/circular_iterator.hpp" | ||
| "${MODULE_PATH}/iterator_pair.hpp" |
There was a problem hiding this comment.
I think claws::iterator_pair could be a container actually, but I'm fine with this too
| ${CMAKE_CURRENT_SOURCE_DIR}/claws/container) | ||
|
|
||
| set(MODULE_PUBLIC_HEADERS | ||
| "${MODULE_PATH}/array_ops.hpp" |
There was a problem hiding this comment.
I don't think this belongs here. But it's deprecated anyway, we'll remove this when claws::vect is in a good state.
| /// | ||
| /// *Defined in "HandleTypes.hpp"* | ||
| /// (TODO: rename to handle_types.hpp)* | ||
| /// |
There was a problem hiding this comment.
Good idea to get rid of the todo. However the part above is a doc comment, it should stay.
There was a problem hiding this comment.
Oh okay, I don't really understand the doc comment then, can you clarify please ?
There was a problem hiding this comment.
It just links the source file, which allows people to easily go and check the implementation
There was a problem hiding this comment.
(Doc comments are preceded by /// or /**)
There was a problem hiding this comment.
Doc was apparently broken (#37 )
Closes #35