Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RSVPs a custom comment type #687

Closed
1 task done
carstingaxion opened this issue Jun 13, 2024 · 5 comments · Fixed by #692
Closed
1 task done

Make RSVPs a custom comment type #687

carstingaxion opened this issue Jun 13, 2024 · 5 comments · Fixed by #692
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@carstingaxion
Copy link
Collaborator

carstingaxion commented Jun 13, 2024

Is your enhancement related to a problem? Please describe.

Designs

  • RSVP status could become a custom taxonomy registered on the comments object type. Here In pseudo-code:
    <?php register_taxonomy_for_object_type( 'rsvp_status', 'comment‘ ); ?>

Advantages:

  • allows to create variations of comment related blocks
  • Does not need a user-account to RSVP
  • No need for the currently used custom DB table

Problems:

further Reading

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carstingaxion carstingaxion added the enhancement New feature or request label Jun 13, 2024
@mauteri mauteri self-assigned this Jun 13, 2024
@mauteri mauteri added this to the 0.30.0 milestone Jun 13, 2024
@carstingaxion
Copy link
Collaborator Author

What about comments and users?

Comments and users are object types that at this point do not support object subtypes. While there is technically a comment_type field in the comments database table, comment types are not clearly scoped in core (for example there is no register_comment_type()), so it was decided to leave them out for now.

For this reason, there are no register_comment_meta() or register_user_meta() functions at this point.

If you are interested in more about the history of these changes, you can read the initial background post for these efforts, or look into the related ticket #38323.

https://make.wordpress.org/core/2018/07/27/registering-metadata-in-4-9-8/

@carstingaxion
Copy link
Collaborator Author

carstingaxion commented Jun 13, 2024

Let us get some Inspiration from

Roles to Taxonomy

WordPress plugin to store user roles and user levels in a taxonomy, for performance.

https://github.com/humanmade/roles-to-taxonomy/blob/master/inc/namespace.php

This was referenced Jun 13, 2024
@carstingaxion carstingaxion linked a pull request Jun 14, 2024 that will close this issue
4 tasks
@MervinHernandez
Copy link
Collaborator

MervinHernandez commented Jun 15, 2024

RE 657 🚩 June 15 Review

✅ Read / not sure what this is about, and the merit of it. I see it's in Mike's hands, so if my assist is needed, we can get to understand this more soon.

@mauteri
Copy link
Contributor

mauteri commented Jun 15, 2024

Mervin this is about how we store data. Right now we have a custom table for RSVP. This is a move to making RSVP save to comments table as a custom comment type. This allows for greater flexibility with ideas we have for non-registered user RSVP in the future, does away with a custom table, and makes exporting/importing RSVP data possible. I have made decent progress on this already.

@MervinHernandez
Copy link
Collaborator

✅ Reviewed June 22

Noted Mike - saw you remarked on a related ticket 692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants