Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP-596: Make online link available after user says they are attending. #597

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Mar 9, 2024

Description of the Change

This change reverts a change made earlier in the project that only made the event link available during the time of the event. Now the event link is available to whoever says they are attending.

Closes #596

How to test the Change

Changelog Entry

Changed - Existing functionality

Credits

Props @mauteri, @nilovelez

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Mar 9, 2024

PR Summary

  • Version Updates in Various Files
    The version identifiers in four different files (online-event/index.asset.php and online-event.asset.php under build/blocks/online-event, and venue/index.asset.php and venue.asset.php under build/blocks/venue) have been updated. This is a routine update to ensure that we are using the most up-to-date version of the codebase.

  • Team Contributor Array Updated
    The array listing our team contributors has been updated in the credits.php file. New contributors have been added and some adjustments have been made - newcomers 'nilovelez' and 'carstenbach' have been added to the gatherpress-team array, and 'carstenbach' has been removed from the contributors array. These changes help us recognize the contributions made by different team members.

  • Tooltip Content Modification
    In OnlineEvent.js, we've updated the tooltip content to better clarify its meaning. The tooltip that used to say 'Link active for attendees during event.' now says 'Link available for attendees only.'. This change ensures that our tooltip message is clearer and more easily understood by users.

@mauteri
Copy link
Contributor Author

mauteri commented Mar 9, 2024

@nilovelez @MervinHernandez if we want to add the online event to the calendar, we are going to need to make that block dynamic, which is fine, but will take a bit of work and like to put it in another ticket for that work. Basically, we can make that a react component like some of the other blocks that listens for changes in RSVP and updates its link from API response. All the pieces for this exist int the Event class and just need to be included in the RSVP response.

@mauteri mauteri merged commit 916cc14 into main Mar 9, 2024
10 checks passed
@mauteri mauteri deleted the GP-596 branch March 9, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPDATE Show Link to Attendees
1 participant