New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Poetry #239
Migrate to Poetry #239
Conversation
12c144a
to
ec6bb87
Compare
Hello @Michionlion, thanks for working on this PR! I think that it is a very good idea to migrate away from Pipenv and to start using Poetry. If there is anything that I need to do in terms of testing or revising some of the configuration files, please let me know. I am glad to help with this PR if you can see a way for me to appropriately contribute. Thanks! 🚀 |
@gkapfham I think this PR is pretty much ready to be merged; it replaces and fully duplicates the existing functionality, although nothing new (like publishing a package to PyPI) has been added. The only reason I've hesitated is that we'll need to update GatorGradle to either use poetry itself (which shouldn't be that difficult), or to require a published python package is installed. Either option will break existing assignments that don't have an explicit version of GatorGrader specified (which I really would like to avoid), so merging this will probably need to wait until the week between Module 1 and Module 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
GatorGrader has long been plagued with a non-user friendly installation interface, and this PR is the first step to rectifying this. By migrating dependency management to Poetry, we will gain more flexibility (and simplicity) in how we architect publishing GatorGrader as a Python package on PyPI, and enabling workflows like
pipx run gatorgrader <some check arguments>
without any extra work needed by the user.This PR is a non-versioned change.
This work-in-progress PR has the core dependency management and GitHub Actions workflow converted to use Poetry. Before marking this as ready for review, I'd like to simplify and merge many of the configuration files to reduce cognitive load for new contributors, and simplify the root directory.
Developers
@Michionlion