Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added good animation and CSS to cards #98

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

Abhinavcode13
Copy link
Contributor

@Abhinavcode13 Abhinavcode13 commented Jun 7, 2023

Updated the our values section of the website.

image

Closes issue number #95

@vercel
Copy link

vercel bot commented Jun 7, 2023

@Abhinavcode13 is attempting to deploy a commit to the sampark's Team Team on Vercel.

A member of the Team first needs to authorize it.

@Abhinavcode13
Copy link
Contributor Author

@gaurav-verma01 please check the PR
Thanks

@Abhinavcode13 Abhinavcode13 changed the title Added good animation and css Added good animation and CSS to cards Jun 7, 2023
@Gaurav-Verma07
Copy link
Owner

@Abhinavcode13 , can you modify this section as in https://www.figma.com/file/OXbrr6UStdn4bHuB5POeRH/sampark?type=design&node-id=0%3A1&t=RCItia46CnzqXFx8-1.
I'm assigning it under level3

Thanks

@Gaurav-Verma07
Copy link
Owner

Also make it responsive as well.

@Abhinavcode13
Copy link
Contributor Author

Abhinavcode13 commented Jun 7, 2023

image

hey @Gaurav-Verma07 you want border in the containers or not , let me know does it look fine.

@Abhinavcode13
Copy link
Contributor Author

Issue number 92 contributor has already worked on responsiveness of website @Gaurav-Verma07 so its sorted I guess ;)

@Gaurav-Verma07
Copy link
Owner

keep same dimensions for all boxes and remove the border

@Abhinavcode13
Copy link
Contributor Author

image

Yes removed border and sized the all boxes same @Gaurav-Verma07

@Abhinavcode13
Copy link
Contributor Author

Please check it now @Gaurav-Verma07
thanks

@Gaurav-Verma07
Copy link
Owner

bro typography is still not good, also card padding and borderRadius not ok.
You can extract these styles from figma as:
image

@Abhinavcode13
Copy link
Contributor Author

Abhinavcode13 commented Jun 8, 2023

Which font is this ? @Gaurav-Verma07 can i know

can please check other two PR , by the time im working on this

@Abhinavcode13
Copy link
Contributor Author

image
it looks good to me in mobile too @Gaurav-Verma07 have a look

@Gaurav-Verma07
Copy link
Owner

Yea bro that looks goods.. we can take care of fonts later

@Gaurav-Verma07
Copy link
Owner

Bug- third box has different border-radius than first two.
Increase space between boxes.
You can open a new issue for these changes

@Gaurav-Verma07 Gaurav-Verma07 merged commit 717d47c into Gaurav-Verma07:main Jun 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants