Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DistortableCollectionSpec.js #1

Merged
merged 1 commit into from Apr 17, 2021
Merged

Update DistortableCollectionSpec.js #1

merged 1 commit into from Apr 17, 2021

Conversation

GauravJ3
Copy link
Owner

@GauravJ3 GauravJ3 commented Apr 21, 2019

removed the new keyword, the old way of creating object.

Fixes #4963 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

removed the new keyword, the old way of creating object.
@GauravJ3
Copy link
Owner Author

@sashadev-sky please review it, thanks for your efforts to help newbies like me for this. Thank You :)

@sashadev-sky
Copy link

@GauravJ3 great job! Thank you for your work!! This org helped me as a newbie a while ago too, it's really amazing.

just a note for the future:

a bigger issue here is that you pushed your PR to your own fork - if you hover main above for the branch comparisons, you will see that it says GauravJS/Leaflet.DistortableImage:main rather than publiclab:main.

try doing git push origin Gaurav33-patch-1 then going to the unforked version of the repo and you will see a prompt to open a PR there.

@GauravJ3
Copy link
Owner Author

ok, i'll do it thank you

@sashadev-sky
Copy link

@GauravJ3 Let me know if you have any problems at all! :)

@GauravJ3 GauravJ3 merged commit f15977e into main Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants