Avoid crashes for files with position information following the timestamp #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thank you for this library, I've used it to create a small tool to extract text from subtitles and it worked great. However, I've had a few crashes on files with position information following the timestamp. Here's a minimal example:
I've fixed this by modifying a bit the parsing code of the timestamp line of
Subtitle.parse
to be able to handle that, and added a test case. I've also edited the documentation to reflect the changes.