Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default options for all http requests #25

Merged
merged 2 commits into from Jul 22, 2015

Conversation

allavena
Copy link
Contributor

Adding possibility to provide default options to use on all http requests. One use case is to provide a user-agent identifying the application to the 3rd party.

Also, added some tests showing how to add request headers to resources requests. These are only tests and don't provide much value, can be removed (that's commit 33a89dd)

@Gazler
Copy link
Owner

Gazler commented Jul 22, 2015

Thanks for the pull requests!

think you might need to rebase in master to remove the commits from the first pull request.

After that I'll merge and release 0.4.0

Thanks,
Gary

@allavena
Copy link
Contributor Author

Mmm. Rebases and not quite going my way. Hopefully this is good to go.

@Gazler
Copy link
Owner

Gazler commented Jul 22, 2015

@allavena Not quite.

If you are struggling with a rebasing the commits, just run the following:

git checkout master
git remote add upstream git@github.com:Gazler/rapidash.git
git fetch upstream
git rebase upstream/master
git cherry-pick c3adef0
git cherry-pick  33a89dd
git branch -D default-http-options
git checkout -b default-http-options
git push origin default-http-options -f

That should ensure only your two new commits are in the pull request.

@allavena
Copy link
Contributor Author

Thanks for the steps. I had stupidly merged my origin branch instead of
force pushing it.

Gary Rennie wrote on 22/07/15 20:20:

@allavena https://github.com/allavena Not quite.

If you are struggling with a rebasing the commits, just run the following:

|git checkout master
git remote add upstream git@github.com:Gazler/rapidash.git
git fetch upstream
git rebase upstream/master
git cherry-pick c3adef0
git cherry-pick 33a89dd
git branch -D default-http-options
git checkout -b default-http-options
git push origin default-http-options -f
|

That should ensure only your two new commits are in the pull request.


Reply to this email directly or view it on GitHub
#25 (comment).

André Allavena, PhD
CTO
Interactive Gaming Entertainment Pty Ltd

Suite 22, 20 Park Rd
Milton Qld 4064

@allavena
Copy link
Contributor Author

Thanks for the steps. I had mistakenly merged my origin branch instead
of force pushing it.

Gary Rennie wrote on 22/07/15 20:20:

@allavena https://github.com/allavena Not quite.

If you are struggling with a rebasing the commits, just run the following:

|git checkout master
git remote add upstream git@github.com:Gazler/rapidash.git
git fetch upstream
git rebase upstream/master
git cherry-pick c3adef0
git cherry-pick 33a89dd
git branch -D default-http-options
git checkout -b default-http-options
git push origin default-http-options -f
|

That should ensure only your two new commits are in the pull request.


Reply to this email directly or view it on GitHub
#25 (comment).

André Allavena, PhD
CTO
Interactive Gaming Entertainment Pty Ltd

Suite 22, 20 Park Rd
Milton Qld 4064

Gazler added a commit that referenced this pull request Jul 22, 2015
Default options for all http requests
@Gazler Gazler merged commit fb6040d into Gazler:master Jul 22, 2015
@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage increased (+0.01%) to 99.502% when pulling b5c825e on allavena:default-http-options into a082186 on Gazler:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants