Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the option for internal damping module for Cosserat rods following warning message #194

Closed
bhosale2 opened this issue Aug 31, 2022 · 2 comments · Fixed by #243
Closed

Remove the option for internal damping module for Cosserat rods following warning message #194

bhosale2 opened this issue Aug 31, 2022 · 2 comments · Fixed by #243
Assignees
@bhosale2
Labels
discussion Topic that needs to be discussed. enhancement New feature or request prio:medium Priority level: medium
Milestone
Version 0.3.1

Comments

@bhosale2
Copy link
Collaborator

Currently, adding damping to the rod via AnalyticalLinearDamper results in the following warning message:

Screen Shot 2022-08-30 at 10 02 31 PM

Per the warning to make a soft change, we should convert the warning message to an error message if the user provides internal damping other than None when initializing a Cosserat rod, and remove related functionality from the cosserat rod equations.

Thoughts @armantekinalp and @skim0119?
@bhosale2 bhosale2 added enhancement New feature or request discussion Topic that needs to be discussed. prio:medium Priority level: medium labels Aug 31, 2022
@bhosale2 bhosale2 added this to the Version 0.3.1 milestone Aug 31, 2022
@armantekinalp
Copy link
Contributor

I agree with you suggestion. As we discussed with @bhosale2, I think we should remove the internal damping functionality, all variables and tests as we planned in v.0.3.1 and update the warning message accordingly.

@bhosale2 bhosale2 self-assigned this Sep 1, 2022
@bhosale2 bhosale2 mentioned this issue May 3, 2023
Merged
@bhosale2 bhosale2 linked a pull request May 3, 2023 that will close this issue
(#194) remove internal damping option for Cosserat rod #243
Merged
bhosale2 added a commit that referenced this issue May 3, 2023
@bhosale2
Merge pull request #243 from bhosale2/194_remove_internal_damping
24f301a 
(#194) remove internal damping option for Cosserat rod
@bhosale2
Copy link
Collaborator Author

bhosale2 commented May 3, 2023

Closed via #243.

@bhosale2 bhosale2 closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhosale2 bhosale2

Labels
discussion Topic that needs to be discussed. enhancement New feature or request prio:medium Priority level: medium
Projects
None yet
Milestone
Version 0.3.1
Development

Successfully merging a pull request may close this issue.

(#194) remove internal damping option for Cosserat rod bhosale2/PyElastica
2 participants
@bhosale2 @armantekinalp