Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: exp damper --> analytical linear damper #163

Merged
merged 4 commits into from
Jul 31, 2022
Merged

refac: exp damper --> analytical linear damper #163

merged 4 commits into from
Jul 31, 2022

Conversation

bhosale2
Copy link
Collaborator

Fixes #161.

@bhosale2 bhosale2 added update Update the codebase prio:high Priority level: high labels Jul 30, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jul 30, 2022
@bhosale2 bhosale2 self-assigned this Jul 30, 2022
@bhosale2 bhosale2 linked an issue Jul 30, 2022 that may be closed by this pull request
Rename ExponentialDamping -> AnalyticalLinearDamping #161
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022 •
edited
Loading

Codecov Report

Merging #163 (0f7852d) into update-0.3.0 (68563bf) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           update-0.3.0     #163   +/-   ##
=============================================
  Coverage         87.62%   87.62%           
=============================================
  Files                43       43           
  Lines              2820     2820           
  Branches            368      368           
=============================================
  Hits               2471     2471           
  Misses              328      328           
  Partials             21       21
Impacted Files Coverage Δ
elastica/rod/factory_function.py 97.69% <ø> (ø)
elastica/dissipation.py 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68563bf...0f7852d. Read the comment docs.

skim0119
skim0119 approved these changes Jul 31, 2022
View reviewed changes
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

armantekinalp
armantekinalp approved these changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a warning message for docs, can you check. Then we can merge.

@bhosale2 bhosale2 merged commit d0cb959 into GazzolaLab:update-0.3.0 Jul 31, 2022
@bhosale2 bhosale2 deleted the 161_rename_exp_damper branch July 31, 2022 03:31
@bhosale2 bhosale2 mentioned this pull request Jul 31, 2022
Closed
@mstoelzle mstoelzle mentioned this pull request Jul 31, 2022
Merged
3 tasks
@skim0119 skim0119 mentioned this pull request Jul 31, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skim0119 skim0119 skim0119 approved these changes

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@bhosale2 bhosale2

Labels
prio:high Priority level: high update Update the codebase
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging this pull request may close these issues.

Rename ExponentialDamping -> AnalyticalLinearDamping
4 participants
@bhosale2 @codecov-commenter @skim0119 @armantekinalp