Update contact model #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds, numba versions of rod-rod and self contact implementations and also test cases
This commit finizalize self-contact validation for numba and it adds validation cases, plectonome and solenoid.
This comment adds a new code to save rod position, radius, directors for topology analysis.
|
@armantekinalp Could you update the new version and explain changes in release? |
This commit updates the rod initialization of RodContactCase examples, instead of inputting poisson ratio we use shear modulus
Codecov Report
@@ Coverage Diff @@
## update-v0.2.1 #40 +/- ##
=================================================
- Coverage 84.97% 81.70% -3.27%
=================================================
Files 39 39
Lines 2436 2542 +106
Branches 338 357 +19
=================================================
+ Hits 2070 2077 +7
- Misses 341 440 +99
Partials 25 25
Continue to review full report at Codecov.
|
|
Here are the solenoid result: 2D_xy_solenoid.mp4And for plectonemes 2D_xy_plectonemes.mp4 |
|
I think after the review we can merge @skim0119 |
skim0119
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding self contact and rod-rod contact models
solves #31