Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language of MK-61 #23

Closed
Russkiy opened this issue Aug 16, 2014 · 3 comments
Closed

Language of MK-61 #23

Russkiy opened this issue Aug 16, 2014 · 3 comments

Comments

@Russkiy
Copy link

Russkiy commented Aug 16, 2014

I propose to add support the syntax of MK-61 (see http://rosettacode.org/wiki/Category:МК-61/52 ), file: http://pastebin.com/BNByHpac .

@cweiske
Copy link
Member

cweiske commented Mar 15, 2017

Thank you for your code. I've put it into a separate branch https://github.com/GeSHi/geshi-1.0/tree/mk-61 for now.

It does not follow the rules for languages, which is why I will not merge it. Current errors:

$ phpunit --filter 'test_langfile with data set "mk-61"'

1) LangCheckTest::test_langfile with data set "mk-61" ('/home/cweiske/Dev/geshi/geshi...61.php')
The following issues were found in /home/cweiske/Dev/geshi/geshi-1.0/tests/../src/geshi/mk-61.php:
[ERROR]   Language file contains no $language_data['COMMENT_MULTI'] specification!
[ERROR]   Language file contains no $language_data['SYMBOLS'] specification!
[ERROR]   Language file contains no $language_data['OBJECT_SPLITTERS'] specification!
[ERROR]   Language file contains no $language_data['SCRIPT_DELIMITERS'] specification!
[ERROR]   Language file contains no $language_data['HIGHLIGHT_STRICT_BLOCK'] specification!
[ERROR]   Language file contains no $language_data['CASE_SENSITIVE'] specification!
[ERROR]   Language file contains no $language_data['URLS'] specification!
[ERROR]   Language file contains no $language_data['STYLES']['COMMENTS'] structure to check!
[ERROR]   Language file contains no $language_data['STYLES']['ESCAPE_CHAR'] structure to check!
[ERROR]   Language file contains no $language_data['STYLES']['BRACKETS'] structure to check!
[ERROR]   Language file contains no $language_data['STYLES']['STRINGS'] structure to check!
[ERROR]   Language file contains no $language_data['STYLES']['METHODS'] structure to check!
[ERROR]   Language file contains no $language_data['STYLES']['SYMBOLS'] structure to check!
[ERROR]   Language file contains no $language_data['STYLES']['SCRIPT'] structure to check!

If someone wants to fix this issues, please do and make a pull request.

@Russkiy
Copy link
Author

Russkiy commented Mar 31, 2017

Thank you very much for your reply.
I rewrote the code, including corrected several errors in regexps.
Code: https://pastebin.com/b2p2hhkg

Now the result of the verification is:

D:\Разработки\php5>php phpunit.phar D:\Server\home\localhost\www\geshi\tests\langchecktest.php
PHPUnit 5.7.17 by Sebastian Bergmann and contributors.

...............................................................  63 / 249 ( 25%)
............................................................... 126 / 249 ( 50%)
.........я╗┐...................................................... 189 / 249 ( 75%)
............................................................    249 / 249 (100%)

Time: 7.8 seconds, Memory: 11.75MB

OK (249 tests, 249 assertions)

@cweiske cweiske closed this as completed in 66e94d3 Apr 4, 2017
@cweiske
Copy link
Member

cweiske commented Apr 4, 2017

Thank you! I've merged the changes.

cweiske added a commit that referenced this issue May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants