Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy nags #37

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Fix Clippy nags #37

merged 1 commit into from
Aug 27, 2018

Conversation

oherrala
Copy link
Contributor

@oherrala oherrala commented Apr 8, 2018

Fix Clippy nags. There should be no functional change.

One warning left unfixed since it would change the API:

warning: this argument is passed by value, but not consumed in the function body
  --> src/format.rs:95:51
   |
95 |   pub fn format_5424_structured_data(&self, data: StructuredData) -> String {
   |                                                   ^^^^^^^^^^^^^^ help: consider taking a reference instead: `&StructuredData`
   |
   = note: #[warn(needless_pass_by_value)] on by default
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.192/index.html#needless_pass_by_value

@Geal Geal merged commit f784f91 into Geal:master Aug 27, 2018
@Geal
Copy link
Owner

Geal commented Aug 27, 2018

Thanks!

@oherrala oherrala deleted the clippy-nags branch August 27, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants