Few changes to get syslog really working #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is superior in two aspects: 1. It detects whether Unix or TCP socket should be used 2. Allows to customize syslog's application name
|
I can split pull request if you like. Commits are pretty isolated, I'm just lazy to provide multiple pull requests (i.e. doing many cherry-picks/rebases) |
Geal
added a commit
that referenced
this pull request
Oct 13, 2015
Few changes to get syslog really working
|
Alright, thanks! |
gkurz
added a commit
to gkurz/rust-syslog
that referenced
this pull request
Jan 15, 2024
The UNIX socket specific initialization functions `init_unix()` and `init_unix_custom()` take care of not setting the hostname in the header. This is based on the assumption that a syslog relay will set the appropriate hostname (see PR Geal#7). The generic initialization function `init()` that supports UNIX, UDP and TCP sockets does set the hostname unconditionally though. Users of this API end up with an extra hostname being added to their logs, as seen with virtiofsd for example : Jan 12 17:03:04 myhostname virtiofsd[70727]: myhostname virtiofsd[70725]: Waiting for vhost-user socket connection... Only set the hostname for UDP and TCP. Signed-off-by: Greg Kurz <groug@kaod.org>
gkurz
added a commit
to gkurz/rust-syslog
that referenced
this pull request
Jan 15, 2024
The UNIX socket specific initialization functions `init_unix()` and `init_unix_custom()` take care of not setting the hostname in the header. This is based on the assumption that a syslog relay will set the appropriate hostname (see PR Geal#7). The generic initialization function `init()` that supports UNIX, UDP and TCP sockets does set the hostname unconditionally though. Users of this API end up with an extra hostname being added to their logs, as seen with virtiofsd for example : Jan 12 17:03:04 myhostname virtiofsd[70727]: myhostname virtiofsd[70725]: Waiting for vhost-user socket connection... Use a distinct `Format3164` structure for each case and only set the hostname for UDP and TCP. Signed-off-by: Greg Kurz <groug@kaod.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init()function for loggingFromStrfor facility, so it can be used for argument parsing and other thingslocalhosthostname from the syslog entry. By specification it seems that "relay" may add it if not exists. And it reality bothjournalctl(systemd) and ubuntursyslogdadd additional hostname if "localhost" is specified. Thejournalctlalso add additional identifier/application name of executable, so I can't even search in logs by--identifier.