Create display comments popup #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GedeonTS
approved these changes
May 20, 2022
There was a problem hiding this comment.
Approved ✅ 🥳 🎉
Hi @Lembani , 👋🏻
Your project is complete!
There is nothing else to say other than... it's time to merge it 🚀
Well done! Congratulations! 🎉
(Highlights) Good points
- Good use of ES6 syntax.
- No linter errors.
- The PR is following the Github workflow.
- Good commit messages.
Optional Suggestions
- Kindly resize the image in the popup, because this would make your project look good.
- It would be better if you added comments in your code because it would make it easier to understand for others.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! 👏👏👏
|
Thanks a lot for the feedback. 👍🏾 |
GedeonTS
reviewed
Oct 19, 2022
Comment on lines
+32
to
+33
| <img src="${movieDetails.image.original}" class="mov-img" alt="Movie Image"> | ||
| </div> |
There was a problem hiding this comment.
[OPTIONAL] I would suggest to resize the image to make it fit the container.
There was a problem hiding this comment.
Noted thanks, will do as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of the Comment popup modal.
Highlights:
Your review will highly be appreciated. 🙏🏾