Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article contains hard coded file location checks for print.css of a theme #1052

Closed
eSilverStrike opened this issue Mar 28, 2020 · 1 comment
Closed

Article contains hard coded file location checks for print.css of a theme #1052

eSilverStrike opened this issue Mar 28, 2020 · 1 comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Milestone
2.2.1sr1

Comments

@eSilverStrike
Copy link
Member

Article should not depend on hard coded file locations for print.css for a theme. Use PLG_getThemeItem instead to retrieve the file location if needed

Related to #1051

Remove hard coded file location checks for common print.css file. Let theme decide if one exists
@eSilverStrike eSilverStrike added the Bug An issue describing unexpected or malicious behaviour. label Mar 28, 2020
@eSilverStrike eSilverStrike added this to the 2.2.1sr1 milestone Mar 28, 2020
eSilverStrike added a commit that referenced this issue Mar 28, 2020
@eSilverStrike
Removed hard coded path for print.css and upped all theme version num…
3a5218c 
…bers

For #1052

By Geeklog 3.0.0 - Article should not depend on hardcoded file locations for print.css for a theme. Use PLG_getThemeItem('core-file-print-css', 'core'); instead

Also update all theme versions since updated in Geeklog v2.2.1sr1
@eSilverStrike
Copy link
Member Author

By Geeklog 3.0.0 - Article should not depend on hardcoded file locations for print.css for a theme. Use PLG_getThemeItem('core-file-print-css', 'core'); instead

Also update all theme versions since updated in Geeklog v2.2.1sr1

eSilverStrike added a commit that referenced this issue Mar 28, 2020
@eSilverStrike
Fixed incorrect variable name
07e97bd 
For #1052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug An issue describing unexpected or malicious behaviour.
Projects
None yet
Milestone
2.2.1sr1
Development

No branches or pull requests
1 participant
@eSilverStrike