Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugs] Prevent Autotags from being interpreted when they appear in JavaScript #448

Closed
mystralkk opened this issue Jan 6, 2016 · 2 comments
Closed

[Bugs] Prevent Autotags from being interpreted when they appear in JavaScript #448

mystralkk opened this issue Jan 6, 2016 · 2 comments
Assignees
@mystralkk
Labels
minor
Milestone
2.1.2

Comments

@mystralkk
Copy link
Member

Reported by @eSilverStrike on 20 Mar 2011 15:28

Version: 1.8.0

Description:
If an autotag appears in JavaScript as a description or label for something (the Configuration Search suffers from this problem) it will always be replaced.

Autotags should not be replaced if they are found in JavaScript. This problem is simlar to the one where unused template variables are replaced in JavaScript code.

Mantis Bugtracker #1293
@mystralkk mystralkk added this to the Future milestone Jan 6, 2016
@mystralkk mystralkk added the minor label Jan 6, 2016
@mystralkk
Copy link
Member Author

Related to #325

@mystralkk mystralkk self-assigned this Jan 2, 2017
@mystralkk mystralkk modified the milestones: 2.1.2, Future Jan 2, 2017
mystralkk added a commit that referenced this issue Jan 2, 2017
@mystralkk
Fixed a bug where autotags in JavaScript were interpreted (bug #448).
849d33a
@mystralkk
Copy link
Member Author

I added GLText::protectJavascript and GLText::unprotectJavascript methods to fix this issue (change set 849d33a). I hope these methods can be used to better handle issue #325, but I am not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mystralkk mystralkk

Labels
minor
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
1 participant
@mystralkk