Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-plugins does not check custom_registration config option where required #720

Closed
eSilverStrike opened this issue Dec 28, 2016 · 1 comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Milestone

Comments

@eSilverStrike
Copy link
Member

I had to add checks for PLG_createUser (and I did for PLG_deleteUser) as it did not check the config option for

$_CONF['custom_registration']

Because of this the custom create user function was being executed for every new user. Not sure if checks need to be added for anymore custom user functions. Need to double check

@eSilverStrike eSilverStrike added the Bug An issue describing unexpected or malicious behaviour. label Dec 28, 2016
@eSilverStrike eSilverStrike added this to the 2.1.2 milestone Dec 28, 2016
@eSilverStrike
Copy link
Member Author

eSilverStrike commented Dec 28, 2016

Just added the check for custom_user_change in function PLG_userInfoChanged

Don't think I need to do this for CUSTOM_user_login in function PLG_loginUser (and for logging out) as not part of creating custom user.

Thoughts on any other functions that should check the custom_registration first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Projects
None yet
Development

No branches or pull requests

1 participant