Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In comment library replace COM_redirect with COM_handle404 on incorrect url #723

Closed
eSilverStrike opened this issue Dec 30, 2016 · 1 comment
Closed

In comment library replace COM_redirect with COM_handle404 on incorrect url #723

eSilverStrike opened this issue Dec 30, 2016 · 1 comment
Assignees
@mystralkk
Labels
Bug An issue describing unexpected or malicious behaviour.
Milestone
2.1.2

Comments

@eSilverStrike
Copy link
Member

For some reason the search engines have found the link on my site and keep visiting this type of url:

http://www.example.com/comment.php?pid=4450&type=staticpages

The comment id does exist but the url is incorrect. I am not sure if Geeklog generated this link or what. (can't find it myself)

The comment library with incorrect urls just redirects the page to the homepage. We should be using COM_handle404 in these spots instead of doing a soft redirect according to the Google guidelines.
@eSilverStrike eSilverStrike added the Bug An issue describing unexpected or malicious behaviour. label Dec 30, 2016
@eSilverStrike eSilverStrike added this to the 2.1.2 milestone Dec 30, 2016
mystralkk added a commit that referenced this issue Dec 30, 2016
@mystralkk
In comment library replaced COM_redirect with COM_handle404 on incorr…
bdcf7ef 
…ect url (bug #723)
@mystralkk
Copy link
Member

Fixed with change set bdcf7ef

@mystralkk mystralkk self-assigned this Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mystralkk mystralkk

Labels
Bug An issue describing unexpected or malicious behaviour.
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
2 participants
@mystralkk @eSilverStrike