Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache clear: forum contains hidden file #910

Closed
remyKobolski opened this issue Jan 12, 2019 · 5 comments
Closed

cache clear: forum contains hidden file #910

remyKobolski opened this issue Jan 12, 2019 · 5 comments
Labels
Bug An issue describing unexpected or malicious behaviour.
Milestone

Comments

@remyKobolski
Copy link

See also #894

The official download contains a file .gitignore which is not deleted by clearCache.
Resulting in the error 'directory cache/forum not empty'.

@eSilverStrike eSilverStrike added the Bug An issue describing unexpected or malicious behaviour. label Jan 13, 2019
@eSilverStrike eSilverStrike added this to the 2.2.1 milestone Jan 13, 2019
@eSilverStrike
Copy link
Member

Thanks for your bug report.

If you look at the code, the only .gitignore file we have is in the root and we don't include that in the release package. I double checked and it is not there.

I am not sure how one got in your /data/cache/ directory.

You downloaded the file named geeklog-2.2.0.tar.gz correct off of Github or the one from here Geeklog.net?

https://www.geeklog.net/downloads/index.php/file_5b324b8ed4c56

@remyKobolski
Copy link
Author

I downloaded the forum plugin and uploaded that to Geeklog using the upload function.
This is because the tarball does not contain the forum. But alas, you know that.

So I did the process again. It f**cks the cache direcory. See screenshot.

cachewithforum

Then I pushed the link to clear the cache. Resulting in

E_WARNING(2) - rmdir(....snipped..../data//forum): Directory not empty @ ....snipped.../myCobol/lib-common.php line 6492

See screenshot 2.

cachewithforum

I am not sure how one got in your /data/cache/ directory.

But I am. I double checked by now and it is definitely there.

@remyKobolski
Copy link
Author

I feel so sorry that I mixed up the cache with the data directory. Above comments clearly refer to the data directory, which contains the directories cache and forum. The latter after uploading the plugin.
I am sure this mixup (on my side) is caused by clearCache, which apparently does much more than clearing the cache.
And still, the forum-plugin-download contains a hidden directory that troubles.

@remyKobolski
Copy link
Author

FYI: the plugin forum forum-2.9.2-2.1.2.zip does NOT contain that hidden file .gitignore.
But forum-2.9.3-2.1.3.zip does.

@eSilverStrike
Copy link
Member

Okay I see the issue. I have updated the forum zip file and removed the .gitignore file. I will have to update the clear cache function to handle hidden files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants