Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building the Install Package empties the "changed-files" file #978

Closed
eSilverStrike opened this issue Oct 29, 2019 · 2 comments
Closed

Building the Install Package empties the "changed-files" file #978

eSilverStrike opened this issue Oct 29, 2019 · 2 comments
Labels
Bug An issue describing unexpected or malicious behaviour.
Milestone

Comments

@eSilverStrike
Copy link
Member

After building the Geeklog Install package for v2.2.1 Beta 1 I notice that the "changed-files" file in the docs directory is empty.

@mystralkk The "changed-files" file seems to update fine I notice when you had a commit on Sept, 28, 2019.

f90c7fa

I thought this file would update when I run the following command:

phing.bat dist

or must I do something else first?

I am wondering if it should be like the language synch where I synch the "changed-files" before the release so it can be recorded in the repository as such (before I tag the commit as release in GitHub)… I guess I can always commit the changed-files file after creating the install package and then tag the commit in GitHub to mark the release.

@eSilverStrike eSilverStrike added the Bug An issue describing unexpected or malicious behaviour. label Oct 29, 2019
@eSilverStrike eSilverStrike added this to the 2.2.1 milestone Oct 29, 2019
@mystralkk
Copy link
Member

The "changed-files" file is created by using git commands, so you have to install git commands on your PC.

eSilverStrike added a commit that referenced this issue Nov 1, 2019
Set git config option diff.renameLimit to a high value

For bug #978
@eSilverStrike
Copy link
Member Author

Right I forgot about installing Git on my new development server. Okay I installed git and the changed-files gets updated and the process completes but I get the following warning via the command prompt.

warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 1692 and retry the command.

Now the changed-files updated and it looks to be correct but I am not sure it is missing files because of the limit so I added a fix to up the renamelimit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants