bug fix 2962 #3094
Merged
bug fix 2962 #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankhadeeproy007
suggested changes
Mar 16, 2020
| @@ -380,7 +380,8 @@ export default (variables /* : * */ = variable) => { | |||
| shadowOpacity: platformStyle === PLATFORM.MATERIAL ? 0.2 : undefined, | |||
| shadowRadius: platformStyle === PLATFORM.MATERIAL ? 1.2 : undefined, | |||
| alignItems: 'center', | |||
| justifyContent: 'space-between' | |||
| justifyContent: 'space-between', | |||
| alignSelf: 'flex-start' | |||
There was a problem hiding this comment.
Can we do it without using alignSelf? The alignment of the button should be left to the user.
There was a problem hiding this comment.
I think alignSelf is fine. I don't find any other solution. The alignment of the button is left to the user. Isn't it?
There was a problem hiding this comment.
I mean the user might want to align it to the center or to the right. So I think it should be the user's choice, can we use alignSelf: 'auto' and see if that works?
There was a problem hiding this comment.
alignSelf: 'auto' will set width to full. But User always has a choice for alignSelf: 'center' whether we set alignSelf: 'flex-start' by default or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Issue: #2962, Buttons fixed.
