Fix line numbers in source maps and stack traces #296
Conversation
| }) | ||
| return lineOfExport | ||
| } | ||
| function getLineOfRVOptions(content) { |
There was a problem hiding this comment.
Lines should be left between functions
| function getLineOfRVOptions(content) { | |
| function getLineOfReactVueOptions(content) { |
| function getLineOfExport(content) { | ||
| var lineOfExport = 0 | ||
| content.split(newLine).some((line, index) => { | ||
| if (line.includes('export')) { |
There was a problem hiding this comment.
This may also match the string export, if it is inside a string and not being used as a keyword. Could we check this in a better way?
| var exportDefaultIndex = code.indexOf('export default') | ||
| var tempString = code.substring(0, exportDefaultIndex) | ||
| var exportDefaultLineNumber = tempString.split('\n').length | ||
| var scriptTagLineNumber = getLineOfExport(parsedSFC.script.content) |
There was a problem hiding this comment.
What if there is code outside the export block, after the imports? We need to test for this
…o fix/source-map-line-numbers
RishabhKarnad
changed the title
…ning tag by adding another loop of mapping.
| return firstLine | ||
| } | ||
|
|
||
| function getFirstNonLineOfText(content, text) { |
There was a problem hiding this comment.
| function getFirstNonLineOfText(content, text) { | |
| function getFirstLineWithoutText(content, text) { |
| @@ -248,3 +271,46 @@ function traverse(ast, nodes = []) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| function getFirstLineOfText(content, text) { | |||
There was a problem hiding this comment.
| function getFirstLineOfText(content, text) { | |
| function getFirstLineWithText(content, text) { |
| @@ -248,3 +271,46 @@ function traverse(ast, nodes = []) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| function getFirstLineOfText(content, text) { | |||
| var firstLine = 0 | |||
There was a problem hiding this comment.
| var firstLine = 0 | |
| let firstLine = 0 |
|
|
||
| function getFirstLineOfText(content, text) { | ||
| var firstLine = 0 | ||
| let splittedContent = content.split(newLine) |
There was a problem hiding this comment.
| let splittedContent = content.split(newLine) | |
| let contentByLine = content.split(newLine) |
| if (!content.includes(text)) { | ||
| return splittedContent.length | ||
| } | ||
| splittedContent.some((line, index) => { |
There was a problem hiding this comment.
Code is confusing. some should be used to check for membership in an array.
Would be better to use findIndex
Would also remove the need for the additional variable firstLine
| } | ||
|
|
||
| function getFirstNonLineOfText(content, text) { | ||
| var firstNonCommentedLine = 0 |
There was a problem hiding this comment.
| var firstNonCommentedLine = 0 | |
| let firstNonCommentedLine = 0 |
Use const for declarations and let only if there is a need to mutate. Avoid var
| if (!content.includes(text)) { | ||
| return 0 | ||
| } | ||
| splittedContent.some((line, index) => { |
There was a problem hiding this comment.
Code is confusing. some should be used to check for membership in an array.
Would be better to use findIndex
Would also remove the need for the additional variable firstNonCommentedLine
Fix #259