Added Switch changes to 'my' command #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a base color to style to resolve encoding issues with colorjs
Changes made for Switch, because Nintendo decided to use friend codes instead of usernames against all earlier communications.
Small name change for Switch (friend code vs. My Nintendo account)
Added Switch changes to ‘my’ command
GeekyDeaks
reviewed
May 4, 2017
There was a problem hiding this comment.
Sorry chap - it looks like you have managed to bring along the changes from sog to master in this commit so it will trash the sog branch in it's current form. I can cherry pick the my.js file for now, but you might want to clean out your master so that it's up-to-date with my sog
|
Seems like I've shit the bed by contaminating one branch with another. Perhaps you can revert to 469420f I'll then make sure my master is in sync with the sog branch and do a pull request from there. The changes I made were hardly 5 minutes work so that shouldn't be too much of an issue.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Switch changes to ‘my’ command