Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create classes #1

Merged
merged 15 commits into from
Oct 20, 2023
Merged

Create classes #1

merged 15 commits into from
Oct 20, 2023

Conversation

GeekyHacks
Copy link
Owner

@GeekyHacks GeekyHacks commented Oct 20, 2023

In this PR I did the following:

  • Created a professional readme
  • Added the linter testing files, and testing file
  • Added the Person, Student, and Teacher classes accordingly
  • Fixed linter errors

Copy link

@mwanawabangona mwanawabangona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GeekyHacks

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations!

Highlights

  • No linter errors ✔️
  • Repo looks professional 💼
  • Solid pull request scroll
  • Good quality commits
  • Good job getting approved on your first try!! 👏 👏 👏

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@GeekyHacks GeekyHacks merged commit a8d5f29 into dev Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants