Add Rspec Unit Tests #8
Conversation
There was a problem hiding this comment.
Hi @GeekyHacks 👋
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Good PR
- Classes tested correectly
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
spec/person_spec.rb
Outdated
| require './person' | ||
|
|
||
| describe Person.new 23, 'Abdu' do | ||
| it { is_expected.to have_attributes(age: 23) } | ||
| it { is_expected.to have_attributes(name: 'Abdu') } | ||
| it { is_expected.to have_attributes(parent_permission: true) } | ||
| end |
There was a problem hiding this comment.
- Good work writing your unit tests, but you forgot to test methods in the class, methods like
can_use_services,correct_name,add_rentalalso testdefault value for the optional name parameter if it is not provided
There was a problem hiding this comment.
Hi Team,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
- add unit tests 👍
- Classes tested correctly 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
|
||
| expect(book.rentals).to include(@rental) | ||
| end | ||
| end |
There was a problem hiding this comment.
- Hi, as stated by the previous reviewer, you forgot to test the method like testing the
default value for the optional name parameter if it is not provided. Can you add this test to complete the test requirement?
There was a problem hiding this comment.
Hi team,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
✅ Descriptive README
✅ Descriptive PR summary
✅ Clean code
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
In this PR we did the following: