Please don't include hidapi inside your source

[benallard]

hidapi is a cross-platform library, the included version is only for linux/hidraw. By doing so, you limit unnecessarily the scope of your library.

Download and compile hidapi separately, then compile/install your project.

[GeertJohan]

@benallard

I wasn't able to do this very easily. There are several errors when doing this..
If you know how to fix I'd be glad to receive patches for them. I might take a look at this at some later time.

[benallard]

I don't know what kind of troubles you are talking about.

For me it was nothing more than

git clone
./bootstrap
./configure
cd mac
make
sudo make install

For you, it might be as easy as sudo apt-get install libhidapi-dev

Would you mind explaining the troubles you had ?

On Aug 21, 2013, at 6:27 PM, Geert-Johan Riemer notifications@github.com wrote:

@benallard

I wasn't able to do this very easily. There are several errors when doing this..
If you know how to fix I'd be glad to receive patches for them. I might take a look at this at some later time.

—
Reply to this email directly or view it on GitHub.

[GeertJohan]

Well theres two things:

1. I need the right version of hidapi for compatibility reasons. So it would require a manual install, not an apt-get install.
2. I want this package to be self-sustainable. Without the need of manually installed libraries. Therefore I included the file. If there's a good way to include the complete hidapi that would be great.. I just didn't have the time to get that to work..

[benallard]

1. You are not bound to a version, you are bound to their interface, which is quite stable, or at least linked to their major version number (I guess).
2. You are not self-sustainable anyway as you require libudev-dev

I still believe that the right way is to let the user independently install the lib.

[GeertJohan]

Merged #5. Thanks!