-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadFile()
implementation that works on Windows.
#44
Conversation
Sorry, this includes my previous PR (about |
Why isn't Bytes() working for you? An error or panic? |
Sorry, missed #45. |
I would like to see if Bytes() can be fixed, before adding a new method that essentially does the same.. |
Is there any optimization that Bytes() does that ReadFile misses ? |
can we just swap the functions ? |
… Windows, and has a somewhat different way to get content).
Ok, I've updated this PR to simply replace thanks! |
Thanks! |
`ReadFile()` implementation that works on Windows.
I've actually also updated box.String() to use box.Bytes() when the data is not embedded. |
The
Bytes()
implementation breaks under Windows. ThisReadFile
could eventually simply replace it. It also is more similar to the stdlib'sioutil.ReadFile
.