Don't kill processes

#927 Sending `kill` to a Dolphin process won't run termination blocks. I've seen cases where the Dolphin UI event handler seems to get stuck after killing a process looping over the events. Sending `terminate` instead which seems to alleviate the problem.
GemTalk · Oct 12, 2022 · 0eae33c · 0eae33c
1 parent 7765c41
commit 0eae33c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sources/JadeDebugger.cls b/sources/JadeDebugger.cls
@@ -376,7 +376,7 @@ reportError: gsError
 	(debugger := self debuggerFor: gsError processOop) notNil
 		ifTrue: 
 			[debugger getProcessList; update.
-			Processor activeProcess kill.
+			Processor activeProcess terminate.
 			self error: 'We should never get here!!'].
 	(#(2709 6005) includes: gsError errorReport number)
 		ifTrue: [^self openDebuggerOnException: gsError].

diff --git a/sources/JadePresenter.cls b/sources/JadePresenter.cls
@@ -338,7 +338,7 @@ waitForAnswer: thingThatCanAnswer
 			[loop isAlive] whileTrue: 
 					[thingThatCanAnswer isDeafObject
 						ifTrue: 
-							[loop kill. "uncerimoneously kill the loop - don't run ensure blocks" 
+							[loop terminate. "uncerimoneously kill the loop - don't run ensure blocks" 
 							^nil].
 					(Delay forMilliseconds: 1) wait]].
 	theAnswer := [deferredValue value] on: Error