Skip to content

Commit

Permalink
Fixes for #193 and #229
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric Winger authored and Eric Winger committed Nov 1, 2018
1 parent 5e97eee commit c6d5b18
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 10 deletions.
21 changes: 13 additions & 8 deletions sources/JadeiteProjectsBrowserPresenter.cls
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ basicAddMethodCategory: string
self issueCommand: (Array with: service).
self selectCategoriesNamed: (Array with: string)!

basicProjectTabLabel
| label |
projectListPresenter selections isEmpty ifTrue: [^'Projects'].
label := projectListPresenter selections size > 1
ifTrue: ['Projects']
ifFalse: [projectListPresenter selection name].
packageListPresenter selections isEmpty ifTrue: [^label].
packageListPresenter selections size > 1 ifTrue: [^label].
^packageListPresenter selection name!

basicRemoveMethodCategories
| service |
service := self selectedClass
Expand Down Expand Up @@ -904,13 +914,7 @@ projectTabLabel
have a unique label. Rather silly, but we'll give the tab a unique number"
| cardNumber label |
label := (projectListPresenter selectionIfNone: [])
ifNil: ['Projects']
ifNotNil:
[:projectService |
packageListPresenter selectionOrNil
ifNil: [projectService name]
ifNotNil: [:packageService | packageService name]].
label := self basicProjectTabLabel.
cardNumber := self parentPresenter view cards indexOf: self view.
^cardNumber printString , ' ' , label!
Expand Down Expand Up @@ -1657,8 +1661,8 @@ updatePackage
updatePackageInfo
| service |
service := packageListPresenter selectionIfNone: [^self].
self updateProjectTab.
service := packageListPresenter selectionIfNone: [^self].
classDefinitionPresenter value: service defaultTemplate.
classDefinitionPresenter view
backcolor: Color white;
Expand Down Expand Up @@ -1757,6 +1761,7 @@ writeProject
!JadeiteProjectsBrowserPresenter categoriesFor: #addSubclass!menu handlers!public! !
!JadeiteProjectsBrowserPresenter categoriesFor: #allClasses!menu handlers!public! !
!JadeiteProjectsBrowserPresenter categoriesFor: #basicAddMethodCategory:!menu handlers support!private! !
!JadeiteProjectsBrowserPresenter categoriesFor: #basicProjectTabLabel!displaying!private! !
!JadeiteProjectsBrowserPresenter categoriesFor: #basicRemoveMethodCategories!menu handlers support!private! !
!JadeiteProjectsBrowserPresenter categoriesFor: #basicRemoveMethods!menu handlers support!private! !
!JadeiteProjectsBrowserPresenter categoriesFor: #basicUnloadProjects:!menu handlers support!private! !
Expand Down
5 changes: 3 additions & 2 deletions sources/Rowan UI Base.pax
Original file line number Diff line number Diff line change
Expand Up @@ -911,13 +911,14 @@ oop
!JadeAutoSystemBrowserPresenter methodsFor!

methodMenuBreak: aMenu
| selection service |
| selection service selectedClass |
methodSourcePresenter view isModified ifTrue: [^self].
selection := methodListPresenter selectionOrNil.
selectedClass := classListPresenter selectionOrNil ifNil: [classHierarchyPresenter selectionOrNil last].
selection ifNil: [^self].
service := RowanMethodService new
selector: selection first asSymbol;
className: classListPresenter selection asSymbol;
className: selectedClass asSymbol;
meta: self isClassSideSelected.
self issueCommand: (Array with: service).
service appendToSourceMenu: aMenu presenter: methodSourcePresenter! !
Expand Down

0 comments on commit c6d5b18

Please sign in to comment.