Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects Browser load doesn't work correctly for update #37

Closed
LisaAlmarode opened this issue Aug 14, 2018 · 7 comments
Closed

Projects Browser load doesn't work correctly for update #37

LisaAlmarode opened this issue Aug 14, 2018 · 7 comments
Assignees

Comments

@LisaAlmarode
Copy link
Member

I have a project loaded. In projects browser, select a class, delete three method categories which each have one method, and add a method in a new category. Then I use menu item project load to reload the disk version.

It deletes added methods (but leaves added method categories),
but it does not add back the deleted methods or method categories. If I open a new projects browser or a dictionaries browser, I see the incorrect set of method categories/methods

The project refresh gets error "JadeiteProjectsBrowserPresented does not understand #refresh.
The Jade list of project refresh makes no difference.

The project list load does load correctly, this is specific to the Projects browser load. After loading from the project list, I can use the and the jade list-of-projects refresh and see correct contents.

@LisaAlmarode LisaAlmarode added this to To do in Jadeite 3.0.x and 3.1.x via automation Aug 14, 2018
@ericwinger
Copy link
Member

It deletes added methods (but leaves added method categories),

Dale told me once that method categories are not known by Rowan except as part of the method. So it doesn't surprise me that a project load "loses" categories. Does this affect the issue report?

Made the projects menu refresh match the Jade menu refresh in 3.0.9.

@ericwinger ericwinger moved this from To do to Review in Jadeite 3.0.x and 3.1.x Aug 14, 2018
ericwinger pushed a commit that referenced this issue Aug 14, 2018
Issue #23 - Project log - better display
Issue #22 - Windows title bar - for some reason some fields are occassionally UTF16. Convert using #asString.
	Use the gci session id instead of stone session id.
Issue #36 - pull not push.
Issue #35 - method recompile needed a method refresh.
Issue #29 - When updating a rowan command, had inadvertently forgot to return the response type.
Issue #34 - Method warnings now give MessageBox warning as in Jade. Not an error.
Issue #37 - Project refresh isn't = jade menu refresh. Made them work & match.
@dalehenrich
Copy link
Member

... yes, method categories are not first class objects in Rowan ... they are added when new, but not removed when empty (not sure that would be desirable behavior anyway) ...

@LisaAlmarode
Copy link
Member Author

Behavior is the same in 3.0.9
When I delete a method category in jadeite, the methods also vanish.
I do not abort or (gemstone) commit, but just reload the project from the project browser, and the methods remain vanished.
I don't care that much about the categories but it's kind of inappropriate to lose the methods.

In 3.0.9, it's more broken since the project list browser load works the same way.

@LisaAlmarode LisaAlmarode moved this from Review to In progress in Jadeite 3.0.x and 3.1.x Aug 15, 2018
@ericwinger ericwinger moved this from In progress to To do in Jadeite 3.0.x and 3.1.x Aug 15, 2018
@ericwinger ericwinger moved this from To do to In progress in Jadeite 3.0.x and 3.1.x Aug 15, 2018
@ericwinger
Copy link
Member

@LisaAlmarode I discovered some bad behavior in rowan when removing categories. For the moment I'm coding around the method removal by moving the methods that would have been deleted into the 'other' method category -- but that's not the correct nor final answer.

When the rowan issue is closed, we can revisit what the proper behavior should be.

@ericwinger ericwinger moved this from In progress to To do in Jadeite 3.0.x and 3.1.x Aug 15, 2018
@ericwinger
Copy link
Member

Jadeite was using the wrong api.

Fixed api in 3.0.11.

Jadeite 3.0.x and 3.1.x automation moved this from To do to Review Aug 16, 2018
@ericwinger
Copy link
Member

ericwinger commented Aug 17, 2018

Also added fancy removal message in 3.0.11 ... & method move was taken back out.

@LisaAlmarode
Copy link
Member Author

This works nicely now.

@LisaAlmarode LisaAlmarode moved this from Review to Done in Jadeite 3.0.x and 3.1.x Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants