Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class Documentation can't be saved or viewed #46

Closed
LisaAlmarode opened this issue Aug 16, 2018 · 8 comments
Closed

Class Documentation can't be saved or viewed #46

LisaAlmarode opened this issue Aug 16, 2018 · 8 comments
Assignees

Comments

@LisaAlmarode
Copy link
Member

In Projects Browser, go to Class Documentation tab. Type in. Save. See UndefinedObject does not understand do: error dialog.

In the Dictionaries Browser, do the same thing and it goes away without being saved.

You cannot view class documentation in the Dictionaries browser when it is present, which is actually serious. Figuring out the codes for DateTime formatting is important.

@LisaAlmarode LisaAlmarode added this to To do in Jadeite 3.0.x and 3.1.x via automation Aug 16, 2018
@ericwinger ericwinger moved this from To do to In progress in Jadeite 3.0.x and 3.1.x Aug 16, 2018
@ericwinger
Copy link
Member

Believe this is now fixed in 3.0.11

Jadeite 3.0.x and 3.1.x automation moved this from In progress to Review Aug 16, 2018
@ericwinger ericwinger modified the milestone: 3.0.11 Aug 16, 2018
ericwinger pushed a commit that referenced this issue Aug 16, 2018
@LisaAlmarode
Copy link
Member Author

I can now save a class comment in the projects browser. However, it doesn't appear to "take" in rowan; it does not make anything dirty (not italic), does not show up in changes, and write to disk does not write it out.

Also the Dictionaries browser, while saving class comments, does not display an existing class comment. This is an important feature since the base is not rowanized.

@LisaAlmarode LisaAlmarode reopened this Aug 17, 2018
Jadeite 3.0.x and 3.1.x automation moved this from Review to In progress Aug 17, 2018
@ericwinger
Copy link
Member

ericwinger commented Aug 17, 2018

I can now save a class comment in the projects browser. However, it doesn't appear to "take" in rowan; it does not make anything dirty (not italic), does not show up in changes, and write to disk does not write it out.

This was reported as a Rowan bug GemTalk/Rowan#306

Still to do:

  • Also the Dictionaries browser, while saving class comments, does not display an existing class comment. This is an important feature since the base is not rowanized.

@ericwinger
Copy link
Member

Closed GemTalk/Rowan#306. I was using the wrong api.

@ericwinger
Copy link
Member

The dictionary browser's comment setter and getter code was fixed as of 3.0.12

Jadeite 3.0.x and 3.1.x automation moved this from In progress to Review Aug 17, 2018
@LisaAlmarode
Copy link
Member Author

Don't see any changes in behavior in 3.0.12 with rowan oscar 93d3bc7.

@LisaAlmarode LisaAlmarode reopened this Aug 17, 2018
Jadeite 3.0.x and 3.1.x automation moved this from Review to In progress Aug 17, 2018
@ericwinger
Copy link
Member

This is a rowan-only fix that just affects the dictionary browser. Try shaw 292f145 for your review.

Jadeite 3.0.x and 3.1.x automation moved this from In progress to Review Aug 18, 2018
@LisaAlmarode
Copy link
Member Author

Testing class comments verified under issue #58, using 3.0.14 and ef4afb6.
If I try to save a change to a base class class comment, I get a walkback, Attempt to add or modify an unpackage method in the class, which is perfectly reasonable.

@LisaAlmarode LisaAlmarode moved this from Review to Done in Jadeite 3.0.x and 3.1.x Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants