Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool dictionaries should be available, preferably displayed in the class creation template #878

Open
ericwinger opened this issue Dec 12, 2022 · 6 comments
Assignees
Labels
bug Something isn't working next up top of todo list

Comments

@ericwinger
Copy link
Member

Jadeite issue GemTalk/Jadeite#964 says:

the pool dictionaries are not displayed in the jadeite project browser. This is wrong.

To clarify, the request is to show Pool Dictionaries in the class creation template in the project browser.

Jadeite gets the class creation template from Rowan but Rowan specifically does not include pool dictionaries in the template:

RwPrjBrowswerToolV2>>classCreationTemplateForClass:hybridBrowser:
<snip>
result addLast: $).
	result
		addAll: lfsp;
		addAll: 'poolDictionaries: '.
	result addAll: '#()'.	"ignored for now"
...
Copy link
Member

Pool dictionary support in Rowan will require base image changes, since currently there is no way to declare a pool dictionary.. a requirement for Rowan support … the Pharo/Squeak community has supported a declarative model based on SharedPools which could be adopted by GemStone

@ericwinger
Copy link
Member Author

I think the request for now is just that Jadeite display the pools read only (somehow). Perhaps an alternate api could be provided by Rowan so that Jadeite could provide some sort of read-only display.

@dalehenrich
Copy link
Member

Classes with Pools cannot be created in Rowan, so there can't be packaged version of a class with pools ... an unpackaged class, can be created:

UserGlobals at: #'XXX_POOL' put: SymbolDictionary new.
Object
	subclass: 'XXX'
instVarNames: #()
classVars: #()
classInstVars: #()
poolDictionaries: { XXX_POOL }
inDictionary: Globals

so in this case there is an argument for showing the pool dictionary (and currently the pool names are ignored for all class definitions).

Would that work for you?

@dalehenrich
Copy link
Member

This image is an unpackaged class, so the answer looks like yes...
image

@ericwinger
Copy link
Member Author

Looks promising. Will defer to @LisaAlmarode about what works for unpackaged classes.

@ericwinger ericwinger added the next up top of todo list label Dec 19, 2023
@dalehenrich
Copy link
Member

Feature request 50838, submitted for consideration in 3.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next up top of todo list
Projects
None yet
Development

No branches or pull requests

2 participants