Add JSON Transaction submitter #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibautBremand
force-pushed
the
feat/submit-json
branch
from
a563204
to
6c15470
Compare
ThibautBremand
force-pushed
the
feat/submit-json
branch
from
6c15470
to
2629597
Compare
| highlight={(code) => highlight(code, languages.json, 'json')} | ||
| padding={10} | ||
| style={{ | ||
| fontFamily: '"Fira code", "Fira Mono", monospace', |
There was a problem hiding this comment.
How do you make sure that this font family is present?
There was a problem hiding this comment.
I would say it is embedded since it's the one used in the documentation of the library
| }`; | ||
|
|
||
| return ( | ||
| <PageWithReturn title="Build Transaction" onBackClick={handleBack}> |
There was a problem hiding this comment.
I would rename it sign transaction locally, build doesn't really mean anything.
There was a problem hiding this comment.
I have renamed into ''Submit Raw Transaction''
FlorianBouron
approved these changes
Dec 4, 2023
ThibautBremand
force-pushed
the
feat/submit-json
branch
from
7e9c040
to
8f65f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.