Skip to content

Commit

Permalink
optimal extraction: ensure VAR=0 pixels aren't used when fitting the …
Browse files Browse the repository at this point in the history
…variance model
  • Loading branch information
chris-simpson committed Mar 3, 2023
1 parent 2bdf247 commit 0b200da
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion gempy/library/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,11 @@ def optimal_extraction(self, data, mask, var, aper_lower, aper_upper,
var = np.full_like(data[ix1:ix2], var_model.amplitude)
var_mask = np.zeros_like(var, dtype=bool)
else:
# straightening and resampling sky lines can create unmasked
# VAR=0 pixels that shouldn't be used in making the variance model
mvar_init = models.Polynomial1D(degree=1)
var_model, var_mask = fit_it(
mvar_init, np.ma.masked_where(mask.ravel(),
mvar_init, np.ma.masked_where(np.logical_or(mask, var == 0).ravel(),
abs(data).ravel()), var.ravel())
var_mask = var_mask.reshape(var.shape)[ix1:ix2]
var = np.where(var_mask, var[ix1:ix2], var_model(data[ix1:ix2]))
Expand Down

0 comments on commit 0b200da

Please sign in to comment.