Skip to content

Commit

Permalink
findSourceApertures() now sends variance=1 to find_peaks() due to 639…
Browse files Browse the repository at this point in the history
  • Loading branch information
chris-simpson committed Aug 14, 2020
1 parent ea9f9b2 commit 31df3fe
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion geminidr/core/primitives_spect.py
Original file line number Diff line number Diff line change
Expand Up @@ -1571,8 +1571,9 @@ def findSourceApertures(self, adinputs=None, **params):
# TODO: find_peaks might not be best considering we have no
# idea whether sources will be extended or not
widths = np.arange(3, 20)
# Send variance=1 since "profile" is already the S/N
peaks_and_snrs = tracing.find_peaks(profile, widths, mask=prof_mask & DQ.not_signal,
variance=None, reject_bad=False,
variance=1.0, reject_bad=False,
min_snr=3, min_frac=0.2)

if peaks_and_snrs.size == 0:
Expand Down

0 comments on commit 31df3fe

Please sign in to comment.