Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox environment with Python 3.6 does not run #112

Closed
b1quint opened this issue Jan 16, 2021 · 3 comments
Closed

Tox environment with Python 3.6 does not run #112

b1quint opened this issue Jan 16, 2021 · 3 comments
Assignees

Comments

@b1quint
Copy link
Contributor

b1quint commented Jan 16, 2021

I had to run some tests locally to verify some regression tests. I didn't remember that Py37 is now a requirement for DRAGONS so I ran the tests using one of the py36 environments. I got the following error:

traceback.txt

My first question is if DRAGONS should run with Py36 or not. I remember some discussions but I don't remember the outcome. If yes, we have to find a solution to the error above. If not, we have to remove py36 from tox.

@b1quint b1quint self-assigned this Jan 16, 2021
@b1quint b1quint added the bug 🐛 Something should be working but it isn't label Jan 16, 2021
@saimn
Copy link
Contributor

saimn commented Jan 18, 2021

On master we require Astropy 4.2 which itself requires Python 3.7

@saimn
Copy link
Contributor

saimn commented Jan 18, 2021

(Python 3.6 only gets security fixes now, and its support ends at the end of the 2021).

@b1quint
Copy link
Contributor Author

b1quint commented Jan 19, 2021

Ok, so this is not a but. I will remove the label.

I kind of recall some discussions related to that but I could not find them on Slack. Thank you for the clarification.

@b1quint b1quint closed this as completed Jan 19, 2021
@b1quint b1quint removed the bug 🐛 Something should be working but it isn't label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants