Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins only runs tests for py37 #113

Open
b1quint opened this issue Jan 16, 2021 · 1 comment
Open

Jenkins only runs tests for py37 #113

b1quint opened this issue Jan 16, 2021 · 1 comment
Labels
continuous integration Continuous integration issues enhancement Performance or usage improvement

Comments

@b1quint
Copy link
Contributor

b1quint commented Jan 16, 2021

The recent issue #112 raised back the problem of which Python versions are supported by DRAGONS. Up to very recently, I remember that Py36 was being supported but is this still true? And what about future python versions? We are not testing them. The tests only run on Py37.

The Unit Tests in Jenkins could run several Python versions since they are short. That would help to verify the installation and potential problems. Very recently, we removed the parallel {} clause from the Unit Tests stage. I suggest adding this clause again to the Jenkinsfile with test cases where we have tests for different python versions.

@b1quint b1quint added enhancement Performance or usage improvement continuous integration Continuous integration issues labels Jan 16, 2021
@b1quint b1quint self-assigned this Jan 16, 2021
@saimn
Copy link
Contributor

saimn commented Jan 18, 2021

We require Python 3.7 (see other ticket), and astroconda does not have packages for Python 3.8/3.9, which limits the number of versions we can test :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Continuous integration issues enhancement Performance or usage improvement
Projects
None yet
Development

No branches or pull requests

2 participants