Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): add mutation filter component #8 #149

Merged
merged 12 commits into from
Apr 23, 2024
Merged

feat(components): add mutation filter component #8 #149

merged 12 commits into from
Apr 23, 2024

Conversation

JonasKellerer
Copy link
Contributor

@JonasKellerer JonasKellerer commented Apr 17, 2024 •
edited by fengelniederhammer

resolves #155

Summary

Adds a new input component to select mutations

  • when the user hits enter or uses the "+" button the typed mutation is validated. If it is valid it is added as a mutation, otherwise nothing happens

Screenshot

grafik

PR Checklist

  • The implemented feature is covered by an appropriate test.

fengelniederhammer
fengelniederhammer requested changes Apr 17, 2024
View reviewed changes
components/src/preact/mutationFilter/mutation-filter.tsx Show resolved Hide resolved
components/src/preact/mutationFilter/mutation-filter.tsx Outdated Show resolved Hide resolved
components/src/preact/mutationFilter/mutation-filter.tsx Outdated Show resolved Hide resolved
components/src/preact/mutationFilter/mutation-filter.tsx Outdated Show resolved Hide resolved
components/src/preact/mutationFilter/mutation-filter.tsx Outdated Show resolved Hide resolved
components/src/utils/mutations.ts Outdated Show resolved Hide resolved
components/src/utils/mutations.ts Outdated Show resolved Hide resolved
components/src/web-components/input/mutation-filter-component.tsx Outdated Show resolved Hide resolved
components/src/web-components/input/mutation-filter-component.tsx Outdated Show resolved Hide resolved
components/src/web-components/input/mutation-filter-component.tsx Show resolved Hide resolved
@JonasKellerer JonasKellerer force-pushed the 8-overview-mutation-and-lineage-filter branch 2 times, most recently from 6bd6561 to 5d6411c Compare April 17, 2024 15:20
@fengelniederhammer fengelniederhammer mentioned this pull request Apr 18, 2024
Closed
@fengelniederhammer fengelniederhammer force-pushed the 8-overview-mutation-and-lineage-filter branch from 5d6411c to 376e206 Compare April 23, 2024 10:07
@fengelniederhammer fengelniederhammer merged commit 49c2f9a into main Apr 23, 2024
4 checks passed
@fengelniederhammer fengelniederhammer deleted the 8-overview-mutation-and-lineage-filter branch April 23, 2024 11:00
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
@fengelniederhammer fengelniederhammer mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoran-chen chaoran-chen chaoran-chen left review comments

@fengelniederhammer fengelniederhammer fengelniederhammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the basic mutation filter component
3 participants
@JonasKellerer @chaoran-chen @fengelniederhammer