-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx losses file has value larger than flows.csv #616
Milestone
Comments
While I believe your statement that there are anomalously high losses, even before that linked commit the output was multiplied by ModelScalingFactor twice! Thanks for finding this bug.
|
lbonaldo
added a commit
that referenced
this issue
Feb 2, 2024
lbonaldo
added a commit
that referenced
this issue
Feb 2, 2024
lbonaldo
added a commit
to lbonaldo/GenX
that referenced
this issue
Feb 2, 2024
lbonaldo
added a commit
that referenced
this issue
Feb 2, 2024
lbonaldo
added a commit
that referenced
this issue
Feb 3, 2024
Fix scaling of tx losses in tlosses.csv #616
Thank you, @gschivley, for opening this issue! Fixed in #622 (main) and #621 (develop). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The transmission losses reported from my model are a couple orders of magnitude larger than the absolute flows for each line. It looks like this commit changed the output calculation from multiplying by
ModelScalingFactor
to multiplying byModelScalingFactor^2
.@cfe316, am I reading the code correctly?
The text was updated successfully, but these errors were encountered: