Tx losses file has value larger than flows.csv

[gschivley]

The transmission losses reported from my model are a couple orders of magnitude larger than the absolute flows for each line. It looks like this commit changed the output calculation from multiplying by ModelScalingFactor to multiplying by ModelScalingFactor^2.

@cfe316, am I reading the code correctly?

[cfe316]

While I believe your statement that there are anomalously high losses, even before that linked commit the output was multiplied by ModelScalingFactor twice! Thanks for finding this bug.

for i in 1:L
   if i in inputs["LOSS_LINES"]
   	tlosses[i,:] = value.(EP[:vTLOSS])[i,:] * ModelScalingFactor     # once
   end
   ...
end
dfTLosses = hcat(dfTLosses, DataFrame(tlosses * ModelScalingFactor, :auto))     # twice

[lbonaldo]

Thank you, @gschivley, for opening this issue! Fixed in #622 (main) and #621 (develop).