Refactor write capactiy value #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existingplant_position -> large_plants i.e. plants large enough to contribute to the CRM. This is just 1MW. make a temporary eTotalCap for brevity.
Standard resources, not touched VRE_STOR yet
cfe316
force-pushed
the
refactor-write-capacity-reserve-margin
branch
from
08b5d4d
to
264258a
Compare
|
Question for @gmantegna : is the risky-hour price determined by the CRM constraint dual supposed to be $1/MW? or $1000/MW? |
lbonaldo
approved these changes
Nov 28, 2023
src/write_outputs/capacity_reserve_margin/write_capacity_value.jl
Outdated
Show resolved
Hide resolved
src/write_outputs/capacity_reserve_margin/write_capacity_value.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Luca Bonaldo <39280783+lbonaldo@users.noreply.github.com>
Co-authored-by: Luca Bonaldo <39280783+lbonaldo@users.noreply.github.com>
|
@cfe316 it should definitely be $/MW. Sorry for the delay. |
cfe316
added a commit
that referenced
this pull request
Nov 29, 2023
This is a followup to #585, to fix a previously un-tested bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor for enhanced readability.
This should help me add fusion in a subsequent PR.
This was tested on the VRE_STOR example and SmallNewEngland/ThreeZones (with CRM turned on). The results are identical other than some outputs which were
-0.0are now0.0.