Create write_operating_reserve_price_revenue.jl #611

sambuddhac · 2024-01-11T20:49:23Z

Description

For printing the operating reserve prices and revenues: This PR adds the file write_operating_reserve_price_revenue.jl which calculates the annual revenue earned by
each resource for providing operating reserve and regulation services. This PR is motivated by and is attempting to
resolve the Issue #46.

The way this PR has been implemented is very similar to how annual energy revenue is calculated. That is, first the
dual variables corresponding to the operating reserve and regulation constraints are evaluated and then those are multiplied by the decision variable values for the regulation and reserves for each generator.

What type of PR is this? (check all applicable)

Feature
Documentation Update
Code Refactor

Related Tickets & Documents

Please use this format to link issue numbers: Fixes #46

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
Code has been tested to ensure all functionality works as intended.
CHANGELOG.md has been updated (if this is a 'notable' change).
I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

This PR does not alter any output. It can be tested simply by running any of the example cases for which the Reserve option is checked.

Post-approval checklist for GenX core developers

After the PR is approved

Check that the latest changes on the target branch are incorporated, either via merge or rebase
Remember to squash and merge if incorporating into develop

For printing the operating reserve prices and revenues

Partial updates to reserve and regulation price documentation and formulation

…gin folder to reserve folder

sambuddhac · 2024-01-29T14:11:53Z

@JesseJenkins @dharik13 could you please check the formulation? @lbonaldo will need some feedback to refurbish the output writing.

…g to resources

…f operating reserve and regulation revenue

typo fix for setup

lbonaldo · 2024-02-05T21:47:25Z

src/load_inputs/load_cap_reserve_margin.jl

@@ -19,6 +19,7 @@ function load_cap_reserve_margin!(setup::Dict, path::AbstractString, inputs::Dic
    mat = extract_matrix_from_dataframe(df, "CapRes")
    inputs["dfCapRes"] = mat
    inputs["NCapacityReserveMargin"] = size(mat, 2)
+    print("Number of CRM types is ",inputs["NCapacityReserveMargin"])


Suggested change

print("Number of CRM types is ",inputs["NCapacityReserveMargin"])

lbonaldo

It looks good to me.

For printing the operating reserve prices and revenues

Partial updates to reserve and regulation price documentation and formulation

…gin folder to reserve folder

…g to resources

…f operating reserve and regulation revenue

cfe316 · 2024-02-05T22:11:26Z

src/write_outputs/reserves/write_operating_reserve_price_revenue.jl

+                                  setup::Dict)::Vector{Float64}
+
+Operating regulation price for each time step.
+This is equal to the dual variable of the regulatin requirement constraint.


Typo: regulatin > regulation.

Typo: "can be obtained form the solver." -> "can be obtained from the solver."

Typo: "of each time steps" --> "in each time step"

Thanks @cfe316 . Addressed these.

cfe316 · 2024-02-05T22:14:45Z

src/write_outputs/reserves/write_operating_reserve_price_revenue.jl

+	if setup["ParameterScale"] == 1
+		rsvrevenue *= scale_factor
+		regrevenue *= scale_factor
+	end


This doesn't need to be wrapped with the if statement since scale_factor is always defined.

Thanks @cfe316 . Addressed this.

cfe316 · 2024-02-05T22:16:37Z

src/write_outputs/write_net_revenue.jl


 Function for writing net revenue of different generation technologies.
 """
-function write_net_revenue(path::AbstractString, inputs::Dict, setup::Dict, EP::Model, dfCap::DataFrame, dfESRRev::DataFrame, dfResRevenue::DataFrame, dfChargingcost::DataFrame, dfPower::DataFrame, dfEnergyRevenue::DataFrame, dfSubRevenue::DataFrame, dfRegSubRevenue::DataFrame, dfVreStor::DataFrame)
+function write_net_revenue(path::AbstractString, inputs::Dict, setup::Dict, EP::Model, dfCap::DataFrame, dfESRRev::DataFrame, dfResRevenue::DataFrame, dfChargingcost::DataFrame, dfPower::DataFrame, dfEnergyRevenue::DataFrame, dfSubRevenue::DataFrame, dfRegSubRevenue::DataFrame, dfVreStor::DataFrame, dfOpRegRevenue::DataFrame, dfOpRsvRevenue::DataFrame)


This is a comment. We should really have an "outputs" dictionary so that we don't have this huge list of dataframes.

cfe316 · 2024-02-05T22:19:24Z

src/write_outputs/write_outputs.jl

@@ -179,6 +179,14 @@ function write_outputs(EP::Model, path::AbstractString, setup::Dict, inputs::Dic
 				dfResMar_slack = write_reserve_margin_slack(path, inputs, setup, EP)
 			end		  
 		end
+
+		if setup["Reserves"]==1 && has_duals(EP) == 1


I realize this code is duplicated from elsewhere in the file, but has_duals returns a boolean, so it's a bit redundant to use an == 1. You can just do if setup["Reserves"]==1 && has_duals(EP).

Thanks @cfe316 . Addressed these in all the instances

Typo fix in documentation. Name of function changed from write_operating_reserve_revenue to write_operating_reserve_regulation_revenue, since the function outputs both reserve and regulation revenue

Replaced all the has_duals(EP)==1 by has_duals(EP), since has_duals(EP) itself returns Boolean

Changed the name of function write_operating_reserve_revenue to write_operating_reserve_regulation_revenue. Also replaced has_duals(EP)==1 by has_duals(EP)

Got rid of the redundant if statement in scale factor

cfe316

Hi Sam,
I'd recommend removing the (... doubled) CHANGELOG entry under Fixed, since this is adding a new feature and not fixing a bug. Usually a PR will be either "Added" or "Fixed" but not both.

cfe316 · 2024-02-06T21:48:23Z

CHANGELOG.md

+- Fixes issue #46
 - Add validation for `Reg_Max` and `Rsv_Max` columns in `Generators_data.csv` when `MUST_RUN` is set to 1 (#576)
 - Fix scaling of transmission losses in write_transmission_losses.jl (#621)
+- Fixes issue #46 (#611)


Hi Sam, this "fixed" line is now duplicated.

I'll again comment that it's useful to summarize for the reader what has been fixed.

Actually, both lines should be removed as the change has been more accurately summarized in the Added section.

Thanks @cfe316 , just did

…his PR is a feature addition

cfe316

Looks good now, thanks!

This reverts commit 91d4678.

Create write_operating_reserve_price_revenue.jl

b01c606

For printing the operating reserve prices and revenues

sambuddhac linked an issue Jan 11, 2024 that may be closed by this pull request

Output Operating Reserve Constraint prices and revenues #46

Closed

sambuddhac added 4 commits January 11, 2024 16:55

Update write_operating_reserve_price_revenue.jl

012959f

Update write_operating_reserve_price_revenue.jl

87fe00c

Partial updates to reserve and regulation price documentation and formulation

Moved wrtiting of operating reserve revenue from capacity reserve mar…

962f18f

…gin folder to reserve folder

Modified write__operating_reserve_price_revenue

e89b0bf

sambuddhac requested review from JesseJenkins, dharik13 and lbonaldo January 29, 2024 14:10

sambuddhac added 3 commits February 4, 2024 21:06

Updated operating reserve and regulation revenue categorized accordin…

6c9dfdd

…g to resources

Updated operating reserve and regulation revenue doc pages

6ec3a46

Updated CHANGELOG.md

435bbe0

sambuddhac marked this pull request as ready for review February 5, 2024 02:45

sambuddhac added 4 commits February 5, 2024 12:06

Modified the write_net_revenue.jl to take into account the addition o…

df459bc

…f operating reserve and regulation revenue

Update write_net_revenue.jl

7c12325

typo fix for setup

Code refactoring for only selecting RSV and REG rows

848b192

Code refactoring for only selecting RSV and REG rows

1ffe28a

lbonaldo reviewed Feb 5, 2024

View reviewed changes

lbonaldo approved these changes Feb 5, 2024

View reviewed changes

sambuddhac added 10 commits February 5, 2024 17:02

Create write_operating_reserve_price_revenue.jl

ee76261

For printing the operating reserve prices and revenues

Update write_operating_reserve_price_revenue.jl

f522df7

Update write_operating_reserve_price_revenue.jl

bae5fee

Partial updates to reserve and regulation price documentation and formulation

Moved wrtiting of operating reserve revenue from capacity reserve mar…

3ac2cce

…gin folder to reserve folder

Modified write__operating_reserve_price_revenue

63e4ed8

Updated operating reserve and regulation revenue categorized accordin…

36c439b

…g to resources

Updated operating reserve and regulation revenue doc pages

c0644e5

Updated CHANGELOG.md

c5d0371

Modified the write_net_revenue.jl to take into account the addition o…

34adab3

…f operating reserve and regulation revenue

Code refactoring for only selecting RSV and REG rows

d777c1b

lbonaldo added 2 commits February 5, 2024 17:05

Clean and fix notation

2fbd18f

Clean write_energy_revenue

5c3cca5

lbonaldo force-pushed the sambuddhac-patch-3 branch from c96be15 to 5c3cca5 Compare February 5, 2024 22:06

cfe316 reviewed Feb 5, 2024

View reviewed changes

sambuddhac added 6 commits February 6, 2024 13:34

Update write_operating_reserve_price_revenue.jl

a334250

Typo fix in documentation. Name of function changed from write_operating_reserve_revenue to write_operating_reserve_regulation_revenue, since the function outputs both reserve and regulation revenue

Update write_net_revenue.jl

475aa47

Replaced all the has_duals(EP)==1 by has_duals(EP), since has_duals(EP) itself returns Boolean

Update write_outputs.jl

3b35243

Changed the name of function write_operating_reserve_revenue to write_operating_reserve_regulation_revenue. Also replaced has_duals(EP)==1 by has_duals(EP)

Update write_operating_reserve_price_revenue.jl

1f4a7f6

Got rid of the redundant if statement in scale factor

Minor typo fix and successful run

d763f73

Updated CHANGELOG.md

99af8ba

cfe316 requested changes Feb 6, 2024

View reviewed changes

sambuddhac and others added 2 commits February 6, 2024 16:57

Updated CHANGELOG.md to eliminate unnecessary entries in Fix, since t…

3cee2c0

…his PR is a feature addition

Cleanup

6503a17

lbonaldo approved these changes Feb 8, 2024

View reviewed changes

Merge branch 'develop' into sambuddhac-patch-3

4469420

cfe316 approved these changes Feb 12, 2024

View reviewed changes

lbonaldo merged commit 91d4678 into develop Feb 13, 2024
9 checks passed

lbonaldo deleted the sambuddhac-patch-3 branch February 13, 2024 00:26

lbonaldo restored the sambuddhac-patch-3 branch February 13, 2024 00:26

lbonaldo added a commit that referenced this pull request Feb 13, 2024

Revert "Create write_operating_reserve_price_revenue.jl (#611)"

2c8e69b

This reverts commit 91d4678.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create write_operating_reserve_price_revenue.jl #611

Create write_operating_reserve_price_revenue.jl #611

sambuddhac commented Jan 11, 2024 •

edited by lbonaldo

Loading

sambuddhac commented Jan 29, 2024

lbonaldo Feb 5, 2024

lbonaldo left a comment

cfe316 Feb 5, 2024

cfe316 Feb 5, 2024

cfe316 Feb 5, 2024

sambuddhac Feb 6, 2024

cfe316 Feb 5, 2024

sambuddhac Feb 6, 2024

cfe316 Feb 5, 2024

cfe316 Feb 5, 2024

sambuddhac Feb 6, 2024

cfe316 left a comment

cfe316 Feb 6, 2024

cfe316 Feb 6, 2024

cfe316 Feb 6, 2024

sambuddhac Feb 6, 2024

cfe316 left a comment

Create write_operating_reserve_price_revenue.jl #611

Create write_operating_reserve_price_revenue.jl #611

Conversation

sambuddhac commented Jan 11, 2024 • edited by lbonaldo Loading

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Checklist

How this can be tested

Post-approval checklist for GenX core developers

sambuddhac commented Jan 29, 2024

Choose a reason for hiding this comment

lbonaldo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cfe316 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cfe316 left a comment

Choose a reason for hiding this comment

sambuddhac commented Jan 11, 2024 •

edited by lbonaldo

Loading