Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS headers #49

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Add CORS headers #49

merged 6 commits into from
Oct 31, 2022

Conversation

capital-G
Copy link
Member

@capital-G capital-G commented Oct 31, 2022 •
edited
Loading

after much confusion I finally found the culprit : strawberry-graphql/strawberry#2290 (comment)

can be dubbed as "3 lines that cost 8 hours"

edit: please dont squash

@capital-G capital-G added the backend stuff that the client does not see label Oct 31, 2022
@capital-G capital-G added this to the Level 3 - dynamic streaming milestone Oct 31, 2022
@capital-G capital-G requested a review from vin-ni October 31, 2022 16:53
@github-actions
Copy link

File Coverage
All files 84% ✅
gencaster/schema.py 69% ✅
gencaster/urls.py 75% ✅
story_graph/models.py 91% ✅
story_graph/types.py 97% ✅
stream/models.py 80% ✅
voice/models.py 82% ✅

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 12080d6

vin-ni
vin-ni approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@vin-ni vin-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@vin-ni vin-ni merged commit 364e044 into main Oct 31, 2022
@capital-G capital-G deleted the cors branch October 31, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vin-ni vin-ni vin-ni approved these changes

Assignees
No one assigned
Labels
backend stuff that the client does not see
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@capital-G @vin-ni