Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nova install #340

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Fix nova install #340

merged 1 commit into from
Apr 24, 2020

Conversation

dmason30
Copy link
Contributor

It appears when you merged in the master build passed but it failed to install nova and therefore didn't run those tests hopefully this fixes it although you might just want to do some trial and error on master instead of merging this PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.308% when pulling 4f2bc01 on dmason30:fix-non-pr-nova into d5c930a on GeneaLabs:master.

@mikebronner
Copy link
Owner

mikebronner commented Apr 24, 2020

Not sure if this was necessary, since the builds are passing? Probably doesn't hurt, though.

@mikebronner mikebronner merged commit b4f9652 into mikebronner:master Apr 24, 2020
@dmason30
Copy link
Contributor Author

dmason30 commented Apr 24, 2020

@mikebronner Its still not working in master see nova is not installing see line 445 on the below travis log:
https://travis-ci.org/github/GeneaLabs/laravel-model-caching/jobs/679088787#L445

In master it should be running 198 tests it is still skipping the nova tests (7 nova tests/ 191 other).

@mikebronner
Copy link
Owner

Actually, it is downloading. Look at line 448. There must be another reason why Nova tests aren't running?

@dmason30 dmason30 deleted the fix-non-pr-nova branch April 24, 2020 16:01
@dmason30
Copy link
Contributor Author

dmason30 commented Apr 24, 2020

@mikebronner Just noticed you moved the nova tests and you added to phpunit.xml
https://github.com/GeneaLabs/laravel-model-caching/blob/master/phpunit.xml#L21

But you didnt add the new test directory to the phpunit.xml.dist which is what travis is using.

Alos at the same time you can remove this:
https://github.com/GeneaLabs/laravel-model-caching/blob/master/phpunit.xml.dist#L15

@mikebronner
Copy link
Owner

Doh! Forgot about php-unit.xml.dist -- thanks for finding that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants