Skip to content

Commit

Permalink
fix(core.gbapp): Fix bug in Teams handling.
Browse files Browse the repository at this point in the history
  • Loading branch information
rodrigorodriguez committed Sep 16, 2021
1 parent 7a76750 commit 7c44669
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/core.gbapp/services/GBConversationalService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ export class GBConversationalService {
}

// TODO: Update botlib.
public async routeNLP(step: GBDialogStep, min: GBMinInstance, text: string): Promise<Boolean> {
public async routeNLP(step: GBDialogStep, min: GBMinInstance, text: string): Promise<boolean> {
return false;
}
public async routeNLP2(step: GBDialogStep, min: GBMinInstance, text: string) {
Expand Down
8 changes: 3 additions & 5 deletions packages/core.gbapp/services/GBMinService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -894,11 +894,9 @@ export class GBMinService {
// Skips if the bot is talking.
const startDialog = min.core.getParam(min.instance, 'Start Dialog', null);

if (context.activity.type === 'conversationUpdate')
{
GBLog.info(`Bot installed on Teams.`);
}
else if (context.activity.type === 'conversationUpdate' &&
if (context.activity.type === 'installationUpdate') {
GBLog.info(`Bot installed on Teams.`);
} else if (context.activity.type === 'conversationUpdate' &&
context.activity.membersAdded.length > 0) {

// Check if a bot or a human participant is being added to the conversation.
Expand Down

0 comments on commit 7c44669

Please sign in to comment.