fix(basic.gblib): Impersonated SET MAX LINES.

GeneralBots · Aug 28, 2022 · 8f373f3 · 8f373f3
1 parent 7e7fb27
commit 8f373f3
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -80,7 +80,7 @@
     "botbuilder-ai": "4.11.0",
     "botbuilder-dialogs": "4.11.0",
     "botframework-connector": "4.11.0",
-    "botlib": "1.10.8",
+    "botlib": "1.10.9",
     "c3-chart-maker": "^0.2.8",
     "cli-spinner": "0.2.10",
     "core-js": "3.14.0",

diff --git a/packages/basic.gblib/services/DialogKeywords.ts b/packages/basic.gblib/services/DialogKeywords.ts
@@ -87,6 +87,11 @@ export class DialogKeywords {
 
   step: GBDialogStep;
 
+  /**
+   * SYSTEM account maxLines, when used with impersonated contexts (eg. running in SET SCHEDULE).
+   */
+  maxLines: number = 2000;
+
   public async getDeployer() {
     return this.min.deployService;
   }
@@ -729,10 +734,15 @@ export class DialogKeywords {
    *
    */
   public async setMaxLines(step, count) {
-    const user = await this.min.userProfile.get(step.context, {});
-    user.basicOptions.maxLines = count;
-    await this.min.userProfile.set(step.context, user);
-    this.user = user;
+    if (step) {
+      const user = await this.min.userProfile.get(step.context, {});
+      user.basicOptions.maxLines = count;
+      await this.min.userProfile.set(step.context, user);
+      this.user = user;
+    }
+    else {
+      await this.maxLines = count;
+    }
   }
 
 

diff --git a/packages/basic.gblib/services/SystemKeywords.ts b/packages/basic.gblib/services/SystemKeywords.ts
@@ -678,12 +678,15 @@ export class SystemKeywords {
 
     // MAX LINES property.
 
-    let maxLines = 1000;
+    let maxLines;
     if (this.dk.user && this.dk.user.basicOptions && this.dk.user.basicOptions.maxLines) {
       if (this.dk.user.basicOptions.maxLines.toString().toLowerCase() !== "default") {
         maxLines = Number.parseInt(this.dk.user.basicOptions.maxLines).valueOf();
       }
     }
+    else {
+      maxLines = this.dk.maxLines;
+    }
 
     // Choose data sources based on file type (HTML Table, data variable or sheet file)
 

diff --git a/packages/core.gbapp/services/GBDeployer.ts b/packages/core.gbapp/services/GBDeployer.ts
@@ -202,7 +202,7 @@ export class GBDeployer implements IGBDeployer {
   /**
    * Deploys a new blank bot to the database, cognitive services and other services.
    */
-  public async deployBlankBot(botId: string, mobile: string = null, email: string = null) {
+  public async deployBlankBot(botId: string, mobile: string, email: string) {
 
     // Creates a new row on the GuaribasInstance table.